Stubserver re-write in Rust #679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robsdedude
force-pushed
the
rust-fun
branch
4 times, most recently
from
b2101dd to
eb9138a
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a comprehensive rewrite of the stub server in Rust, replacing the existing Python implementation. The rewrite provides improved performance through reduced startup times and polling intervals for the Rust implementation, while maintaining backward compatibility with the existing test infrastructure.
- Adds a complete Rust implementation of the bolt stub server (
boltstub_rs/) - Adds Docker build support for including the Rust binary in test environments
- Implements conditional logic to use either Python or Rust stub servers based on environment variables
Reviewed Changes
Copilot reviewed 55 out of 57 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/stub/shared.py | Adds Rust stub server support with conditional execution logic and updated parsing functions |
| tests/stub/routing/scripts/v3/router_adb_then_bdb.script | Adds missing ELSE clause to handle edge cases in routing logic |
| tests/stub/driver_parameters/test_client_agent_strings.py | Updates HELLO message parsing to use new as_parsed_dict helper |
| tests/stub/driver_parameters/test_bookmark_manager.py | Updates BEGIN message parsing to use new as_parsed_dict helper |
| runner_image/Dockerfile | Adds multi-stage build to compile and include Rust boltstub binary |
| runner.py | Adds build context support for including Rust source in Docker builds |
| docker.py | Extends build function to support build contexts for multi-stage Docker builds |
| boltstub_rs/* | Complete Rust implementation including WebSocket support, PackStream serialization, Bolt protocol handling, and some test coverage |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.